[Info-vax] Listeners in VMS Basic, was: Re: Integrity iLO Configuration?

Stephen Hoffman seaohveh at hoffmanlabs.invalid
Mon Jul 12 16:16:09 EDT 2021


On 2021-07-09 23:45:31 +0000, Dave Froble said:

> Just because some agree, doesn't make them right.
> 
> But, Ok, a practical example, tell me, too many comments, not enough 
> comments, what?
> 
> ;+
> ;       Base block must be > 0
> ;       # of blocks must be > 0 & < 128
> ;       End block must be <= EOF block
> ;       Grant lock if caller has exclusive access to the file
> ;-
> 
>          MOVZWL  #SS$_ABORT,R0           ; Assume failure
>          TSTL    R3                      ; Base block zero?
>          BNEQU   020$                    ; No, continue
> 010$:   BRW     RETURN                  ; Yes, return
> 020$:   TSTL    R4                      ; Block count zero?
>          BEQLU   010$                    ; Yes, return
>          CMPL    #127,R4                 ; Block count <= 127
>          BLSSU   010$                    ; No, return
>          MOVAB   -1(R3)[R4],R5           ; Last block to lock
>          CMPL    CIB_L_FILSIZ(R7),R5     ; LE filesize?
>          BGEQU   030$                    ; Yes, continue
>          MOVL    CIB_L_FILSIZ(R7),R5     ; Else lock only to EOF


BLEQU, not BLSSU? Or BLSSU with 128?

I'd suggest using a string constant for 127 (or 128) rather than a 
magic number, too.


-- 
Pure Personal Opinion | HoffmanLabs LLC 




More information about the Info-vax mailing list